Re: gold patch committed: Fix handling of writable .eh_frame section

[Ian Lance Taylor <iant at google dot com>]

Cary Coutant <ccoutant@google.com> writes:

>> I also fixed a
>> possible lurking problem in the patch of 2010-10-17 in that
>> increase_relro was not reset in the case where set_section_addresses is
>> called a second time.
>
>> Â Â Â Â(Layout::set_segment_offsets): Reset increase_relro before calling
>> Â Â Â Âset_section_addresses a second time.
>
> Am I not correct in reasoning that set_section_addresses() will not
> get called a second time if there is a relro segment? Aligning the
> relro segment is incompatible with trying to realign the data segment
> to save a page.

Argh, you are correct.  The patch is harmless but useless.

Ian