This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] AMD bdver2 processors 2/2 - TBM
On Tue, Jan 18, 2011 at 8:35 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Jan 14, 2011 at 2:22 PM, Quentin Neill
> <quentin.neill.gnu@gmail.com> wrote:
>> On Tue, Jan 4, 2011 at 5:02 PM, Quentin Neill
>> <quentin.neill.gnu@gmail.com> wrote:
>>> On Tue, Jan 4, 2011 at 3:00 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> On Tue, Jan 4, 2011 at 12:26 PM, Quentin Neill
>>>> <quentin.neill.gnu@gmail.com> wrote:
>>>>> On Tue, Dec 28, 2010 at 8:03 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>>> On Tue, Dec 28, 2010 at 5:56 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>>>> On Mon, Dec 20, 2010 at 2:33 PM, Quentin Neill
>>>>>>> <quentin.neill.gnu@gmail.com> wrote:
>>>>>>>> These two patches add support for BMI and TBM ISAs to be introduced in
>>>>>>>> AMD bdver2 processors.
>>>>>>>>
>>>>>>>> The full encoding specification is delayed, however I have posted
>>>>>>>> abbreviated specs on the gcc mailing list:
>>>>>>>> BMI: http://gcc.gnu.org/ml/gcc-patches/2010-10/msg01766.html
>>>>>>>> TBM: http://gcc.gnu.org/ml/gcc-patches/2010-10/msg01767.html
>>>>>>>>
>>>>>>>> Tested on x86-64 with "make -k check RUNTESTFLAGS=i386.exp".
>>>>>>>>
>>>>>>>
>>>>>>> Why is "bextr" in both BMI and TBM? ?Please double check you don't have
>>>>>>> instructions in both BMI and TBM.
>>>>>>>
>>>>>>
>>>>>> I see. The TBM one takes an immediate operand.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> H.J.
>>>>>
>>>>> Refreshed with updated Changelogs.
>>>>>
>>>>> Tested on x86-64 with "make -k check RUNTESTFLAGS=i386.exp".
>>>>>
>>>>> Okay to commit?
>>>>
>>>> Didn't you submit a patch with both BMI and TBM?
>>>>
>>>> --
>>>> H.J.
>>>
>>> You are right, Grrrr.
>>> I attached the wrong patch file.
>>> I'll refresh the both patches after addressing objdump feedback you gave.
>>> --
>>> Quentin.
>>>
>>
>> The final TBM patch after merging/rebasing on top of the BMI patch,
>> including tbm-intel.d tests.
>> This passes "make RUNTESTFLAGS=i386 check" (without the k).
>> Okay to commit?
>
> Are you 100% sure that you passed "make RUNTESTFLAGS=i386 check"
> when you committed your change?
>
You didn't check in generated files nor update gas/i386/ilp32/x86-64-arch-2.d.
I had to fix it again.
--
H.J.
---
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index c463b63..2e3af6e 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2011-01-18 H.J. Lu <hongjiu.lu@intel.com>
+
+ * gas/i386/ilp32/x86-64-arch-2.d: Add tbm flag and TBM instruction
+ pattern.
+
2011-01-17 Quentin Neill <quentin.neill@amd.com>
* gas/i386/tbm.s: New.
diff --git a/gas/testsuite/gas/i386/ilp32/x86-64-arch-2.d
b/gas/testsuite/gas/i386/ilp32/x86-64-arch-2.d
index 779a95a..6b41a2d 100644
--- a/gas/testsuite/gas/i386/ilp32/x86-64-arch-2.d
+++ b/gas/testsuite/gas/i386/ilp32/x86-64-arch-2.d
@@ -1,5 +1,5 @@
#source: ../x86-64-arch-2.s
-#as: -march=generic64+avx+vmx+smx+xsave+xsaveopt+aes+pclmul+fma+movbe+ept+clflush+syscall+rdtscp+3dnowa+sse4a+svme+abm+padlock+bmi
+#as: -march=generic64+avx+vmx+smx+xsave+xsaveopt+aes+pclmul+fma+movbe+ept+clflush+syscall+rdtscp+3dnowa+sse4a+svme+abm+padlock+bmi+tbm
#objdump: -dw
#name: x86-64 (ILP32) arch 2
@@ -38,4 +38,5 @@ Disassembly of section .text:
[ ]*[a-f0-9]+: f3 0f bd d9 lzcnt %ecx,%ebx
[ ]*[a-f0-9]+: 0f a7 c0 xstore-rng
[ ]*[a-f0-9]+: c4 e2 60 f3 c9 blsr %ecx,%ebx
+[ ]*[a-f0-9]+: 8f e9 60 01 c9 blcfill %ecx,%ebx
#pass