Re: [patch binutils gas]: Let binutils understand DOS-paths (2 of 4)

[Kai Tietz <ktietz70 at googlemail dot com>]

2011/3/2 Hans-Peter Nilsson <hans-peter.nilsson@axis.com>:
>> Date: Mon, 28 Feb 2011 08:58:15 +0100
>> From: Kai Tietz <ktietz70@googlemail.com>
>
>> ChangeLog binutils/
>> 2011-02-28 ?Kai Tietz
>>
>> ? ? ? * debug.c (debug_start_source): Use filename_(n)cmp.
>> ? ? ? * ieee.c (ieee_finish_compilation_unit): Likewise.
>> ? ? ? (ieee_lineno): Likewise.
>> ? ? ? * nlmconv.c (main): Likewise.
>> ? ? ? * objcopy.c (strip_main): Likewise.
>> ? ? ? (copy_main): Likewise.
>> ? ? ? * objdump.c (show_line): Likewise.
>> ? ? ? (dump_reloc_set): Likewise.
>> ? ? ? * srconv.c (main): Likewise.
>> ? ? ? * wrstabs.c (stab_lineno): Likewise.
>>
>> ChangeLog gas/
>> 2011-02-28 ?Kai Tietz
>>
>> ? ? ? * depend.c (register_dependency): Use filename_(n)cmp.
>> ? ? ? * dwarf2dbg.c (get_filenum): Likewise.
>> ? ? ? * ecoff.c (add_file): Likewise.
>> ? ? ? (ecoff_generate_asm_lineno): Likewise.
>> ? ? ? * input-scrub.c (new_logical_line_flags): Likewise.
>> ? ? ? * listing.c (file_info): Likewise.
>> ? ? ? (listing_newline): Likewise.
>> ? ? ? * remap.c (remap_debug_filename): Likewise.
>> ? ? ? * stabs.c (generate_asm_file): Likewise.
>> ? ? ? (stabs_generate_asm_lineno): Likewise.
>>
>> Tested for x86_64-w64-mingw32, i686-pc-cygwin, and
>> x86_64-pc-linux-gnu. Ok for apply?
>
> This broke (for example) mips-elf.
> (H.J.'s reversion wasn't complete.)
>
> gcc -DHAVE_CONFIG_H -I. -I/tmp/hpautotest-sim/binusrc/src/gas ?-I. -I/tmp/hpautotest-sim/binusrc/src/gas -I../bfd -I/tmp/hpautotest-sim/binusrc/src/gas/config -I/tmp/hpautotest-sim/binusrc/src/gas/../include -I/tmp/hpautotest-sim/binusrc/src/gas/.. -I/tmp/hpautotest-sim/binusrc/src/gas/../bfd -DLOCALEDIR="\"/tmp/hpautotest-sim/mips-elf/p/share/locale\"" ?-W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT ecoff.o -MD -MP -MF .deps/ecoff.Tpo -c -o ecoff.o /tmp/hpautotest-sim/binusrc/src/gas/ecoff.c
> cc1: warnings being treated as errors
> /tmp/hpautotest-sim/binusrc/src/gas/ecoff.c: In function 'add_file':
> /tmp/hpautotest-sim/binusrc/src/gas/ecoff.c:2260: warning: implicit declaration of function 'filename_cmp'
> make[4]: Leaving directory `/tmp/hpautotest-sim/mips-elf/b/gas'
> make[3]: Leaving directory `/tmp/hpautotest-sim/mips-elf/b/gas'
> make[2]: Leaving directory `/tmp/hpautotest-sim/mips-elf/b/gas'
> make[1]: Leaving directory `/tmp/hpautotest-sim/mips-elf/b'
> make[4]: *** [ecoff.o] Error 1
>
> Maybe ecoff.c is just missing an #include.
>
> brgds, H-P
>
>

Thanks for reporting. Yes, indeed in ecoff.c is the include for
filenames.h missing. I am curious that I didn't saw this by building
for --enable-targets=all.

ChangeLog

          * ecoff.c: Add filenames.h include.

Could you please the attached patch. Thanks in advance. Ok to apply if
problem is solved?

Regards,
Kai

Index: ecoff.c
===================================================================
RCS file: /cvs/src/src/gas/ecoff.c,v
retrieving revision 1.29
diff -u -3 -r1.29 ecoff.c
--- ecoff.c     28 Feb 2011 18:32:52 -0000      1.29
+++ ecoff.c     2 Mar 2011 15:56:35 -0000
@@ -39,6 +39,7 @@
 #include "aout/stab_gnu.h"

 #include "safe-ctype.h"
+#include "filenames.h"

 /* Why isn't this in coff/sym.h?  */
 #define ST_RFDESCAPE 0xfff