This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Supplemtal patch for use only dwarf_vma types in dwarf code

From: Nick Clifton <nickc at redhat dot com>
To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
Cc: "'Kai Tietz'" <ktietz70 at googlemail dot com>, "'H.J. Lu'" <hjl dot tools at gmail dot com>, "'Binutils'" <binutils at sourceware dot org>
Date: Fri, 25 Mar 2011 18:04:38 +0000
Subject: Re: [RFA] Supplemtal patch for use only dwarf_vma types in dwarf code
References: <AANLkTimPMPKd=Hfz-1e_aSw_iQsdm2SMK5hwR0sd+tga@mail.gmail.com> <-8460070221060995487@unknownmsgid> <AANLkTingRFjfLtvFFVpJXuu1L_bV-0whUZOsL8z+s2L6@mail.gmail.com> <-6930711422310680743@unknownmsgid> <AANLkTimW3VCc977dAmo47m=k3KoNThFKcno1ALsQg=66@mail.gmail.com> <AANLkTimHC_cR=Zb4JHBhBWcjn0Ypya1uzsjzZZRehSk=@mail.gmail.com> <4D63D49D.90101@redhat.com> <AANLkTi=v4XEzssnXK8z91n80jMe9bhtZh+2PtXY+_4vR@mail.gmail.com> <-2339605939192327273@unknownmsgid> <AANLkTi=SOpyBkHYFQRdsytdPb7b_DZ6Cf01DoZw4tLw+@mail.gmail.com> <-3886800211494155692@unknownmsgid> <AANLkTimZ59JPpUSmqEaGGdT6c=pb+5mLQ1giCz8o=JB0@mail.gmail.com> <1561346207520594884@unknownmsgid> <AANLkTinC+rpP_G8gFn=EGgDYgBtQkyLw14QvKmZrPRn+@mail.gmail.com> <5095785081977025060@unknownmsgid> <AANLkTik9=KVF+gX9yR-=EtnHDnnOmWG2wGaKqbDXn9Os@mail.gmail.com> <00d601cbd4f0$c911af10$5b350d30$@muller@ics-cnrs.unistra.fr> <4D8CB1F5.6020108@redhat.com> <000a01cbeb04$0c0e6e60$242b4b20$@muller@ics-cnrs.unistra.fr>

Hi Pierre,

   I have no real idea if those three cases are
really variables that can reach up to values that
do not fit in 4-bytes but it can not really hurt, can it?

Agreed.

ChangeLog entry:
2011-03-25  Pierre Muller<muller@ics.u-strasbg.fr>

	* dwarf.c (decode_location_expression): Use dwarf_vmatoa
	function to display DW_OP_addr OP.
	(process_debug_info): Use dwarf_vma type for local variables
	length and type_offset.

Approved and applied - note: there were a couple of places where the "length" variable was being displayed in a printf() style output, so I updated these to use the dwarf_vmatoa() function as well.

Cheers
  Nick

Follow-Ups:
- RE: [RFA] Supplemtal patch for use only dwarf_vma types in dwarf code
  - From: Pierre Muller

References:
- Re: [RFC-v2] Use only dwarf_vma types in dwarf code
  - From: Nick Clifton
- [RFA] Supplemtal patch for use only dwarf_vma types in dwarf code
  - From: Pierre Muller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]