This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] incremental 7/18: restructure class Incremental_binary
- From: Ian Lance Taylor <iant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 30 Mar 2011 13:08:40 -0700
- Subject: Re: [gold patch] incremental 7/18: restructure class Incremental_binary
- References: <BANLkTi=A9muk9HwHY8vURMYHMu04hRWcjw@mail.gmail.com>
Cary Coutant <ccoutant@google.com> writes:
> This patch restructures the Incremental_binary and
> Sized_incremental_binary classes to provide the methods that will be
> needed during an incremental update.
>
> -cary
>
>
> 2011-03-28 Cary Coutant <ccoutant@google.com>
>
> * incremental-dump.cc (dump_incremental_inputs): Change signature
> to take a Sized_incremental_binary; change caller. Use readers
> in Sized_incremental_binary.
> * incremental.cc
> (Sized_incremental_binary::find_incremental_inputs_sections):
> Rename do_find_incremental_inputs_sections to this.
> (Sized_incremental_binary::setup_readers): New function.
> (Sized_incremental_binary::do_check_inputs): Check
> has_incremental_info_ flag; move setup code to setup_readers;
> use input readers.
> (Sized_incremental_binary::do_file_is_unchanged): New function.
> (Sized_incremental_binary::do_get_input_reader): New function.
> * incremental.h (class Incremental_binary): Move to end of file.
> (Incremental_binary::file_is_unchanged): New function.
> (Incremental_binary::do_file_is_unchanged): New function.
> (Incremental_binary::Input_reader): New class.
> (Incremental_binary::get_input_reader): New function.
> (class Sized_incremental_binary): Move to end of file.
> (Sized_incremental_binary::Sized_incremental_binary): Setup the
> input section reader classes.
> (Sized_incremental_binary::has_incremental_info): New function.
> (Sized_incremental_binary::inputs_reader): New function.
> (Sized_incremental_binary::symtab_reader): New function.
> (Sized_incremental_binary::relocs_reader): New function.
> (Sized_incremental_binary::got_plt_reader): New function.
> (Sized_incremental_binary::do_file_is_unchanged): New function.
> (Sized_incremental_binary::Sized_input_reader): New class.
> (Sized_incremental_binary::get_input_reader): New function.
> (Sized_incremental_binary::find_incremental_inputs_sections):
> Rename do_find_incremental_inputs_sections to this.
> (Sized_incremental_binary::setup_readers): New function.
> (Sized_incremental_binary::has_incremental_info_): New data member.
> (Sized_incremental_binary::inputs_reader_): New data member.
> (Sized_incremental_binary::symtab_reader_): New data member.
> (Sized_incremental_binary::relocs_reader_): New data member.
> (Sized_incremental_binary::got_plt_reader_): New data member.
> (Sized_incremental_binary::current_input_file_): New data member.
The actual patch appears to be missing.
Ian