This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch bfd]: Prevent possible buffer overflow on pdata-section sorting
2011/4/9 Alan Modra <amodra@gmail.com>:
> On Sat, Apr 09, 2011 at 03:17:31PM +0200, Kai Tietz wrote:
>> 2011/4/9 Alan Modra <amodra@gmail.com>:
>> > On Sat, Apr 09, 2011 at 11:50:45AM +0200, Kai Tietz wrote:
>> >> Ok, AFAICS it is enough here to set rawsize at one place.
>> >
>> > Yes.
>> >
>> >> Just for bss-section we don't want to set rawsize.
>> >
>> > Why is that?
>> >
>> >> --- src.orig/bfd/coffcode.h ? 2011-04-09 10:29:19.000000000 +0200
>> >> +++ src/bfd/coffcode.h ? ? ? ?2011-04-09 11:46:45.938100500 +0200
>> >> @@ -3297,6 +3297,11 @@ coff_compute_section_file_positions (bfd
>> >> ? ? ? ?if (!(current->flags & SEC_HAS_CONTENTS))
>> >> ? ? ? continue;
>> >
>> > Won't the above test exclude .bss anyway?
>>
>> Hmm, this might be bogus. I've tested it without this check and it
>> seems to work still. So I can remove this check. Ok then for apply?
>
> Yes, OK.
>
> --
> Alan Modra
> Australia Development Lab, IBM
>
Ok, applied.
Thanks,
Kai