This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix ld testcases on c6x


On 05/11/2011 01:56 PM, Alan Modra wrote:
> On Wed, May 11, 2011 at 01:10:23PM +0200, Bernd Schmidt wrote:
>> +if { ![ld_assemble $as "$as_opt $srcdir/$subdir/tbss.s" tmpdir/tbss.o ]
>> +     || ![ld_assemble $as "$as_opt $srcdir/$subdir/frame.s" tmpdir/frame.o] }
> 
> Passing options like this in the "source" parameter of ld_assemble
> isn't the cleanest way.

I just followed lib/ld-lib.exp. I must say I dislike using ASFLAGS as in
ld-frv/tls.exp; it seems more error-prone since it has to be restored at
every return. So I went the other route and added a ld_assemble_flags
function. I'll give you some time to object to this version and check it
in as preapproved later today if I don't hear otherwise.


Bernd

Attachment: as-flags.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]