This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed] Fix mipsisa32-linux-gnu linker failures
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: binutils at sourceware dot org
- Date: Wed, 11 May 2011 13:55:14 +0100
- Subject: [committed] Fix mipsisa32-linux-gnu linker failures
Alan's nod in the direction of mipsisa32-linux-gnu made me look at
the 3 linker failures there. They were caused by missing checks for
$has_newabi.
These tests passed on mipsel-linux-gnu because of the default
"from-abi" architecture. One fix would therefore have been to
force the architecture on the command line. I think it's better
to test with the default architecture where possible though,
so we'd need some machinery to conditionally add an architecture
option only when one was needed.
In the meantime, this patch makes the handling of these three
tests consistent with all the other NewABI tests. Tested on
mipsisa32-linux-gnu and applied.
Richard
ld/testsuite/
* ld-mips-elf/mips-elf.exp: Add missing $has_newabi tests.
Index: ld/testsuite/ld-mips-elf/mips-elf.exp
===================================================================
--- ld/testsuite/ld-mips-elf/mips-elf.exp 2011-01-17 15:58:41.000000000 +0000
+++ ld/testsuite/ld-mips-elf/mips-elf.exp 2011-05-11 13:47:02.000000000 +0100
@@ -160,8 +160,10 @@ if $has_newabi {
if { $linux_gnu } {
run_dump_test "rel32-o32"
- run_dump_test "rel32-n32"
- run_dump_test "rel64"
+ if { $has_newabi } {
+ run_dump_test "rel32-n32"
+ run_dump_test "rel64"
+ }
# The first test checks that a mixed PIC/non-PIC relocatable link
# will not introduce any stubs itself, but will flag PIC functions
# for the final link.
@@ -333,7 +335,9 @@ if {$has_newabi} {
}
if { $linux_gnu } {
- run_dump_test "textrel-1"
+ if { $has_newabi } {
+ run_dump_test "textrel-1"
+ }
run_dump_test "got-page-1"
if $has_newabi {
run_dump_test "got-page-2"