This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [ARM] signed zero
- From: Nick Clifton <nickc at redhat dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Thu, 02 Jun 2011 16:19:03 +0100
- Subject: Re: [ARM] signed zero
- References: <4DDA696F.40607@codesourcery.com>
Hi Nathan,
This patch fixes up things so that, for instance
ldr r0,[r1,#-0]
is encoded correctly.
tested on arm-eabi, ok?
Approved - please apply - except...
There are two places where you have code like this:
{
skip_whitespace (q);
if (*q == '#') q++;
skip_whitespace (q);
if (*q == '-')
inst.operands[i].negative = 1;
}
The first if-statement should have its body indented on a new line:
{
skip_whitespace (q);
if (*q == '#')
q++;
skip_whitespace (q);
if (*q == '-')
inst.operands[i].negative = 1;
}
Plus if we are being really picky, the second skip only needs to be
inside the body of the first if-statement:
{
skip_whitespace (q);
if (*q == '#')
{
q++;
skip_whitespace (q);
}
if (*q == '-')
inst.operands[i].negative = 1;
}
Cheers
Nick