Re: [committed] PR gas/12915: MIPS prev_nop_frag assert

[Richard Sandiford <rdsandiford at googlemail dot com>]

Richard Sandiford <rdsandiford@googlemail.com> writes:
> The problem is that this check also includes any hazards generated by
> the previous instructions in the ".set noreorder" block too, even though
> they aren't relevant here; the user is asserting that there are no such
> hazards.  That is, we had:
>
>     INSN1         1-+
>     INSN2         2-+  1-+
>     INSN3         3-+  2-+  1-+
>     INSN4         4-+  3-+  2-+  1-+
>     .set noreorder  |    |    |    |
>     INSN5         5-+  4-+  3-+  2-+
>     INSN6              5-+  4-+  3-+
>     INSN7                   5-+  4-+
>     INSN8                        5-+
>
> Which is a pretty basic oversight (of mine) really :-(
>
> The patch below restricts the check to instructions outside the current
> ".set noreorder" block.  Tested on mips64-linux-gnu and applied.

Hmm, actually, I now see that this isn't right for the 24k errata
(and pessimistic for the vr4130 errata).  I'll test a different
approach...

Richard