This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: patches that could interest you
On Jun 28, 2011, at 12:49 PM, Fawzi Mohamed wrote:
>
> On Jun 28, 2011, at 9:46 AM, ext Tristan Gingold wrote:
>
>> On Jun 27, 2011, at 5:34 PM, Fawzi Mohamed wrote:
>>
>>> Hi all,
>>>
>>> while working on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 I made a some changes to binutils.
>>> Thanks to Tristan the main fix of that bug is already in, but this small change should also be added in some way, as it
>>> adds the forgotten ignore of routine_64 load command (which is the equivalent of the 32 bit one, and contains the
>>> init routines of the dylib).
>>>
>>> Suppress the "unable to read unknown load command" when loading a 64 bit dylib with init routines
>>
>> Now committed with this ChangeLog entry:
>>
>> 2011-06-28 Fawzi Mohamed <fawzi.mohamed@nokia.com>
>>
>> * mach-o.c (bfd_mach_o_read_command): Also ignore
>> BFD_MACH_O_LC_ROUTINES_64.
>>
>> Tristan.
>
> thank you very much, I will add the changelog next time.
Sure.
Please, also make the subject more explicit (such as in this case: [Patch]: ignore ROUTINES_64 load command on Darwin).
Tristan.
>
> Fawzi
>>
>>>
>>> Index: bfd/mach-o.c
>>> ===================================================================
>>> RCS file: /cvs/src/src/bfd/mach-o.c,v
>>> retrieving revision 1.57
>>> diff -f -u -r1.57 mach-o.c
>>> --- bfd/mach-o.c 14 Jan 2011 12:35:56 -0000 1.57
>>> +++ bfd/mach-o.c 27 Jun 2011 15:06:23 -0000
>>> @@ -2523,6 +2523,7 @@
>>> case BFD_MACH_O_LC_FVMFILE:
>>> case BFD_MACH_O_LC_PREPAGE:
>>> case BFD_MACH_O_LC_ROUTINES:
>>> + case BFD_MACH_O_LC_ROUTINES_64:
>>> break;
>>> case BFD_MACH_O_LC_SUB_FRAMEWORK:
>>> case BFD_MACH_O_LC_SUB_UMBRELLA:
>>>
>>
>