This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch/gas]: simplify frag_grow
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Steve Ellcey <sje at cup dot hp dot com>
- Cc: Tristan Gingold <gingold at adacore dot com>, binutils at sourceware dot org
- Date: Tue, 26 Jul 2011 21:06:40 -0400 (EDT)
- Subject: Re: [patch/gas]: simplify frag_grow
- References: <201107262013.p6QKDg308492@sapph05.cup.hp.com>
On Tue, 26 Jul 2011, Steve Ellcey wrote:
>
> Tristan Gingold wrote:
>
> > The 'while' loop can only be executed once. The function 'frag_new' can
> > either succeed or abort via exit (it uses xmalloc to allocate memory as
> > defined by as.h).
>
> This doesn't seem to be true. I used the previous version of frag_grow
> and put some print statements in frag_grow and I see multiple passes
> through the while loop in some calls to frag_grow. If I change the
> while to an if (so that it can only be done once) and make no other
> changes, my test case fails.
I'm guessing that bug is also the cause for these regressions
for cris-elf exposed by Tristan's changes:
Running /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/cris/cris.exp ...
FAIL: gas/cris/rd-bkw5
FAIL: gas/cris/rd-bkw5b
FAIL: gas/cris/rd-bkw5pic
FAIL: gas/cris/rd-bkw5v32
FAIL: gas/cris/rd-bkw5v32pic
gas.log (beware, cutnpasted):
../as-new --underscore --em=criself -o dump.o
/tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/c
ris/rd-bkw5.s
Executing on host: sh -c {../as-new --underscore --em=criself
-o dump.o /tmp/hpautotest-binutils/bs
rc/src/gas/testsuite/gas/cris/rd-bkw5.s 2>&1} /dev/null gas.out
(timeout = 300)
/tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/cris/rd-bkw5.s:
Assembler messages:
/tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/cris/rd-bkw5.s:38:
Fatal error: can't extend fra
g 24576 chars
/tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/cris/rd-bkw5.s:
Assembler messages:
/tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/cris/rd-bkw5.s:38:
Fatal error: can't extend fra
g 24576 chars
/tmp/hpautotest-binutils/cris-axis-elf/gas/testsuite/../../binutils/objdump
-dr dump.o
Executing on host: sh -c
{/tmp/hpautotest-binutils/cris-axis-elf/gas/testsuite/../../binutils/objdum
p -dr dump.o >dump.out 2>gas.stderr} /dev/null (timeout =
300)
/tmp/hpautotest-binutils/cris-axis-elf/gas/testsuite/../../binutils/objdump:
'dump.o': No such file
FAIL: gas/cris/rd-bkw5
I think I'd like to ask Tristan to please revert and investigate
at your own convenience.
brgds, H-P