This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] MIPS: microMIPS clean-ups


Richard Sandiford <rdsandiford@googlemail.com> writes:
> But leave it as it is.  It's my fault for not communicating clearly
> enough, and most of the other hunks were bikeshed stuff.

Actually, the hunk I've reverted below was more than that.  The assert
was originally added before some inline mask checks, but it doesn't make
any sense now.

Tested on x86_64-linux-gnu and applied.

Richard


gas/
	* config/tc-mips.c (nops_for_vr4130): Revert previous commit.

Index: gas/config/tc-mips.c
===================================================================
--- gas/config/tc-mips.c	2011-07-30 07:23:00.000000000 +0100
+++ gas/config/tc-mips.c	2011-07-30 07:23:03.000000000 +0100
@@ -3275,7 +3275,6 @@ nops_for_vr4130 (int ignore, const struc
     if (MF_HILO_INSN (hist[i].insn_mo->pinfo))
       {
 	/* Extract the destination register.  */
-	gas_assert (!mips_opts.micromips);
 	mask = gpr_write_mask (&hist[i]);
 
 	/* No nops are needed if INSN reads that register.  */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]