This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: gas segfault in files with groups and some error

From: Alan Modra <amodra at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: binutils at sourceware dot org
Date: Fri, 5 Aug 2011 12:37:32 +0930
Subject: Re: gas segfault in files with groups and some error
References: <20110804102407.GM26813@bubble.grove.modra.org> <CAMe9rOrvGGqmmXh8G2jD3GOApCS-rxttjLe=ZTenHDtDgbw=2A@mail.gmail.com> <CAMe9rOpncFooB5GJBpKExO_t_gd5M_bjNw7w9vYcBSvNiXgysA@mail.gmail.com> <20110805023319.GO26813@bubble.grove.modra.org> <CAMe9rOqEBWMjEOxL=pf3XuNARbUma=Ub-hibG1=1Y_hiMrYCKw@mail.gmail.com>

On Thu, Aug 04, 2011 at 07:36:16PM -0700, H.J. Lu wrote:
> On Thu, Aug 4, 2011 at 7:33 PM, Alan Modra <amodra@gmail.com> wrote:
> > On Thu, Aug 04, 2011 at 01:55:47PM -0700, H.J. Lu wrote:
> >> We should simply call bfd_cache_close_all on error.
> >> I checked this in as an obvious fix.
> >
> > Thanks for fixing this.  The patch is OK, although it does make as -Z
> > even more useless.
> 
> Does anyone depend on it?  I think we should just ignore it.

Yes, that's why I gave an explicit approval to your maybe not so
obvious patch.

-- 
Alan Modra
Australia Development Lab, IBM

References:
- gas segfault in files with groups and some error
  - From: Alan Modra
- Re: gas segfault in files with groups and some error
  - From: H.J. Lu
- Re: gas segfault in files with groups and some error
  - From: H.J. Lu
- Re: gas segfault in files with groups and some error
  - From: Alan Modra
- Re: gas segfault in files with groups and some error
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]