Re: [PING] [RFA/ARM]: Patch to workaround ARM1176 BLX (immediate) Thumb to ARM issue

[Nick Clifton <nickc at redhat dot com>]

Hi Matthew,

> Please can someone review this patch?

Sorry for the delay.

> > bfd/ChangeLog:
> > 2011-07-29 Matthew Gretton-Dann<matthew.gretton-dann@arm.com>
> >
> > * bfd-in.h (bfd_elf32_arm_set_target_relocs): Update prototype.
> > * bfd-in2.h (bfd_elf32_arm_set_target_relocs): Likewise.
> > * elf32-arm.c (elf32_arm_link_hash_table): New field.
> > (elf232_arm_link_hash_table_create): Initialise new field.
> > (check_use_blx): Change test depending on fix_arm1176.
> > (bfd_elf32_arm_set_target_relocs): Set fix_arm1176 from
> > command line options.
> >
> > ld/ChangeLog:
> > 2011-07-29 Matthew Gretton-Dann<matthew.gretton-dann@arm.com>
> >
> > * emultempl/armelf.em (fix_arm1176): New variable.
> > (arm_elf_create_output_section_statements): Pass
> > fix_arm1176 option to bfd backend.
> > (OPTION_FIX_ARM1176): New define.
> > (OPTION_NO_FIX_ARM1176): Likewise.
> > (PARSE_AND_LIST_LONGOPTS): Add new command line options.
> > (PARSE_AND_LIST_OPTIONS): Likewise.
> > (PARSE_AND_LIST_ARGS_CASES): Likewise.
> > * ld.texinfo: Document new command line options.
> >
> > ld/testsuite/ChangeLog:
> > 2011-07-29 Matthew Gretton-Dann<matthew.gretton-dann@arm.com>
> >
> > * ld-arm/arm-elf.exp (armelftests): Update for new command-line
> > options.
> > (armeabitests): Update for new command-line options, and add
> > new test cases.
> > * ld-arm/fix-arm1176.s: Add test case.
> > * ld-arm/fix-arm1176-off.d: Likewise.
> > * ld-arm/fix-arm1176-on.d: Likewise.

Approved - please apply.

But ...

> > +@cindex ARM1176 erratum workaround
> > +@kindex --fix-arm1176
> > +@kindex --no-fix-arm1176
> > +The @samp{--fix-arm1176} switch enables a link-time workaround for an
> > erratum
> > +in certain ARM1176 processors. The workaround is enabled by default
> > if you
> > +are targetting ARM v6 (excluding ARM v6T2) or earlier. It can be
> > disabled
> > +unconditionally by specifying @samp{--no-fix-arm1176}.
> > +
> > +Please contact ARM for further details.

It would be nice to include the URL to ARM's Erratum here.

Cheers
  Nick