Re: is_elf_format usage in ld testsuite?

[Andreas Tobler <andreast-list at fgznet dot ch>]

On 04.11.11 03:20, Hans-Peter Nilsson wrote:
> On Thu, 3 Nov 2011, Andreas Tobler wrote:
> > ld-elf/binutils.exp:
> > ---
> > # Make sure that binutils can correctly handle ld output in ELF.
> >
> > if { ![istarget *-*-linux*]
> >       &&  ![istarget *-*-gnu*]} {
> > 	return
> > }
> > ---
> >
> > These tests run fine under FreeBSD for example. But these targets are not on
> > the test above.
> > Is there a special reason why we do not check with the is_elf_format proc
> > instead?
>
> Some of those tests require the target to support shared
> libraries, which is not true for all binutils ELF targets.

Ok.

Then I take it this way, everywhere in the test suite (binutils/ld) 
where we 'check' on ELF I use the already existing pattern to match my 
target. So for the above I'd add my target like this:

---
if { ![istarget *-*-linux*]
	&&  ![istarget *-*-freebsd*] <--- my target.
      	&&  ![istarget *-*-gnu*]} {
 	return
}
---

Am I right?

Thank you for the response!
Andreas