This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix CRIS bug exposed by "MIPS/BFD: Don't make debug section relocs dynamic"


> From: Tristan Gingold <gingold@adacore.com>
> Date: Fri, 2 Dec 2011 09:12:12 +0100

> On Dec 1, 2011, at 11:46 AM, Mikael Pettersson wrote:
> 
> > Hans-Peter Nilsson writes:
> >> I see this test fails for m68k-linux too, if someone feels pity
> >> (no listed maintainer).
> >> 
> >> No regressions tested cris-elf cris-linux.
> >> Can I put this on the 2.22 branch too?
> 
> Yes.

Did you mean to reply to Mikael Pettersson's patch and request
for 2.22?  (More likely than replying to me a second time, but
better safe than sorry. :)

Mikael, I don't see you mentioned in copyright.list, so if
unless it's already in progress, I'd suggest you take care of
the GNU copyright assignment paperwork, even if IMHO this
particular patch was a small enough.

> >> bfd:
> >> 	* elf32-cris.c (cris_elf_check_relocs) <plt accounting for
> >> 	R_CRIS_8, R_CRIS_16, and R_CRIS_32>: Move early break for
> >> 	non-SEC_ALLOC sections before GOT and PLT accounting.

> > I've implemented a similar change for elf32-m68k.c which fixes
> > ld-elf/comm-data.exp for m68k-linux, with no testsuite regressions
> > on head or the 2.22 release.
> > 
> > As for m68k maintainers, I looked around in recent ChangeLogs,
> > and both Andreas Schwab and Maxim Kuvyrkov seem likely candidates
> > so I've added them to the Cc: list.
> > 
> > Ok for head and 2.22 branch?

> > 2011-12-01  Mikael Pettersson  <mikpe@it.uu.se>
> > 
> > 	* elf32-m68k.c (elf_m68k_check_relocs) <R_68K_8, R68K_16, R_68K_32>: For
> > 	non-SEC_ALLOC sections break before GOT and PLT accounting.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]