This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: Improve handling of DW_LNE_define_file


On Jan 19, 2012, at 2:32 PM, Michael Eager wrote:

> On 01/12/2012 04:05 AM, Tristan Gingold wrote:
> 
>> index a775818..08f472f 100644
>> --- a/binutils/dwarf.c
>> +++ b/binutils/dwarf.c
> 
>> @@ -288,7 +289,11 @@ process_extended_line_op (unsigned char *data, int is_stmt)
>>        printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,&  bytes_read, 0)));
>>        data += bytes_read;
>>        printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,&  bytes_read, 0)));
>> -      printf ("%s\n\n", name);
>> +      data += bytes_read;
>> +      printf ("%s", name);
>> +      if (data - orig_data != len)
> 
> This should be
>         if ((unsigned int) (data - orig_data) != len)
> or change len to "int".
> 
> I prefer changing len.   I can check in obvious patch.

I think the cast is cleaner as 'len' was already used as unsigned.
I will commit the fix.

Sorry for not having seen that.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]