This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch binutils/ld]: Fix name-issue in def-file parser PR /13657
- From: Alan Modra <amodra at gmail dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 14 Feb 2012 13:10:03 +1030
- Subject: Re: [patch binutils/ld]: Fix name-issue in def-file parser PR /13657
- References: <CAEwic4Y=mdxeWnsTfvuQUV-gi9MNH79HC5+Qi_s8X0+681_fLw@mail.gmail.com>
On Sat, Feb 11, 2012 at 03:12:47PM +0100, Kai Tietz wrote:
> Index: src/binutils/testsuite/binutils-all/dlltool.exp
> ===================================================================
> --- src.orig/binutils/testsuite/binutils-all/dlltool.exp
> +++ src/binutils/testsuite/binutils-all/dlltool.exp
> @@ -53,6 +53,17 @@ if { "$target_xfail" == "yes" } {
> setup_xfail *-*
> }
>
> +verbose "$DLLTOOL -l libversion.a --def $srcdir/$subdir/version.def" 1
> +catch "exec $DLLTOOL -l libersion.a --def $srcdir/$subdir/version.def" err
> +
> +if ![string match "" $err] then {
> + send_log "$err\n"
> + verbose "$err" 1
> + fail "dlltool (version.dll)"
> +} else {
> + pass "dlltool (version.dll)"
> +}
> +
> verbose "$DLLTOOL -p prefix --leading-underscore -l tmpdir/libalias.a
> -d $srcdir/$subdir/alias.def $dlltool_gas_flag" 1
> catch "exec $DLLTOOL -p prefix --leading-underscore -l
> tmpdir/libalias.a -d $srcdir/$subdir/alias.def $dlltool_gas_flag" err
>
This patch disassociated a setup_xfail from "dlltool -p", making
that test fail on non-pe x86 targets.
* binutils-all/dlltool.exp: Add setup_xfail.
Index: binutils/testsuite/binutils-all/dlltool.exp
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/dlltool.exp,v
retrieving revision 1.16
diff -u -p -r1.16 dlltool.exp
--- binutils/testsuite/binutils-all/dlltool.exp 11 Feb 2012 20:02:02 -0000 1.16
+++ binutils/testsuite/binutils-all/dlltool.exp 14 Feb 2012 02:39:02 -0000
@@ -64,6 +64,10 @@ if ![string match "" $err] then {
pass "dlltool (version.dll)"
}
+if { "$target_xfail" == "yes" } {
+ setup_xfail *-*
+}
+
verbose "$DLLTOOL -p prefix --leading-underscore -l tmpdir/libalias.a -d $srcdir/$subdir/alias.def $dlltool_gas_flag" 1
catch "exec $DLLTOOL -p prefix --leading-underscore -l tmpdir/libalias.a -d $srcdir/$subdir/alias.def $dlltool_gas_flag" err
--
Alan Modra
Australia Development Lab, IBM