This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix presumed type clash in "ld - fix for bug 13343"
- From: Alan Modra <amodra at gmail dot com>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: binutils at sourceware dot org
- Date: Sat, 18 Feb 2012 22:03:19 +1030
- Subject: Re: Fix presumed type clash in "ld - fix for bug 13343"
- Authentication-results: mr.google.com; spf=pass (google.com: domain of amodra@gmail.com designates 10.68.73.225 as permitted sender) smtp.mail=amodra@gmail.com; dkim=pass header.i=amodra@gmail.com
- References: <20120217141346.GA5314@bubble.grove.modra.org> <201202180419.q1I4JtB1016420@ignucius.se.axis.com>
On Sat, Feb 18, 2012 at 05:19:55AM +0100, Hans-Peter Nilsson wrote:
> Index: ldmisc.c
> ===================================================================
> RCS file: /cvs/src/src/ld/ldmisc.c,v
> retrieving revision 1.41
> diff -p -u -r1.41 ldmisc.c
> --- ldmisc.c 17 Feb 2012 14:09:57 -0000 1.41
> +++ ldmisc.c 18 Feb 2012 04:07:15 -0000
> @@ -241,12 +241,12 @@ vfinfo (FILE *fp, const char *fmt, va_li
> case 'S':
> /* Print script file and linenumber. */
> {
> - node_type node;
> + etree_type node;
> etree_type *tp = va_arg (arg, etree_type *);
>
> if (tp == NULL)
> {
> - tp = (etree_type *) &node;
> + tp = &node;
> tp->type.filename = ldlex_filename ();
> tp->type.lineno = lineno;
> }
Huh, that's how I had it to start with. Silly me for saving a few
bytes. My 4.4.3-4ubuntu5 and gcc mainline builds were fine. OK.
--
Alan Modra
Australia Development Lab, IBM