This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] PR ld/13621


> From: Richard Henderson <rth@redhat.com>
> Date: Mon, 30 Jan 2012 01:56:49 +0100


> 	  * testsuite/ld-elf/zerosize1.d: New file.
> 	  * testsuite/ld-elf/zerosize1.s: New file.

> diff --git a/ld/testsuite/ld-elf/zerosize1.d b/ld/testsuite/ld-elf/zerosize1.d
> new file mode 100644
> index 0000000..0da5171
> --- /dev/null
> +++ b/ld/testsuite/ld-elf/zerosize1.d
> @@ -0,0 +1,10 @@
> +#source: start.s
> +#source: zerosize1.s
> +#ld:
> +#readelf: -s
> +
> +# Check that xyzzy is not placed in the ABS section.
> +
> +#...
> + +[0-9]+: +[0-9a-f]+ +0 +NOTYPE +GLOBAL +DEFAULT +ABS xyzzy
> +#pass

Would it be right to change this as follows, making it pass for
MIPS targets too?  See the PR.  I don't know the MIPS ELF rules well
enough to call it obvious.

ld/testsuite:
	PR ld/13789
	* ld-elf/zerosize1.d: Allow xyzzy to be either OBJECT or NOTYPE.

diff --git a/ld/testsuite/ld-elf/zerosize1.d b/ld/testsuite/ld-elf/zerosize1.d
index ee69592..43187f0 100644
--- a/ld/testsuite/ld-elf/zerosize1.d
+++ b/ld/testsuite/ld-elf/zerosize1.d
@@ -6,5 +6,5 @@
 # Check that xyzzy is not placed in the .text section.
 
 #...
- +[0-9]+: +[0-9a-f]+ +0 +NOTYPE +GLOBAL +DEFAULT +ABS xyzzy
+ +[0-9]+: +[0-9a-f]+ +0 +(OBJECT|NOTYPE) +GLOBAL +DEFAULT +ABS xyzzy
 #pass

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]