This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] BFD and GAS support for x86_64-nacl target
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: binutils at sourceware dot org, David Sehr <sehr at google dot com>
- Date: Fri, 16 Mar 2012 15:13:32 -0700
- Subject: Re: [PATCH] BFD and GAS support for x86_64-nacl target
- References: <x57j4ntonr6x.fsf@frobland.mtv.corp.google.com>
On Fri, Mar 16, 2012 at 2:58 PM, Roland McGrath <mcgrathr@google.com> wrote:
> This adds support for the x86_64-nacl target flavor to BFD and GAS.
> It passes 'make -C gas check'. ?Full linker support still remains to
> be implemented, but the BFD parts for linking are there, including
> PLT generation for x86_64-nacl's idiosyncratic ABI. ?I used local
> hacks (not in this patch) to get a linker built and test that a PLT
> comes out as intended for both elf32 and elf64 variants.
>
> Ok for trunk?
>
>
...
> diff --git a/gas/configure.tgt b/gas/configure.tgt
> index 06fb6ca..99a276f 100644
> --- a/gas/configure.tgt
> +++ b/gas/configure.tgt
> @@ -183,7 +183,10 @@ case ${generic_target} in
> ? i386-*-elf) ? ? ? ? ? ? ? ? ? ? ? ? ?fmt=elf ;;
> ? i386-*-kaos*) ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?fmt=elf ;;
> ? i386-*-bsd*) ? ? ? ? ? ? ? ? ? ? ? ? fmt=aout em=386bsd ;;
> - ?i386-*-nacl*) ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?fmt=elf ?em=nacl ;;
> + ?i386-*-nacl*) ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?fmt=elf em=nacl
> + ? ?case ${cpu} in
> + ? ? ?x86_64*) ? ? ? ? ? ? ? ? ? ? ? ? arch=x86_64:32 ;;
^^^^^^^^^^^^^^
Why is x86_64:32?
Do you need to support x86_64-*-nacl* target?
> + ? ?esac ;;
> ? i386-*-netbsd0.8) ? ? ? ? ? ? ? ? ? ?fmt=aout em=386bsd ;;
> ? i386-*-netbsdpe*) ? ? ? ? ? ? ? ? ? ?fmt=coff em=pe ;;
> ? i386-*-netbsd*-gnu* | \
Thanks.
--
H.J.