This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] VAX/BFD: Remove duplicate shared output check
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: binutils at sourceware dot org
- Date: Mon, 7 May 2012 07:23:21 +0100 (BST)
- Subject: [PATCH] VAX/BFD: Remove duplicate shared output check
Hi,
There's no need to check if we're making a shared object here again as
the whole block this piece is in is already only executed if info->shared.
No regressions for vax-linux-gnu. OK to apply?
2012-05-07 Maciej W. Rozycki <macro@linux-mips.org>
bfd/
* elf32-vax.c (elf_vax_relocate_section)
<R_VAX_8, R_VAX_16, R_VAX_32>: Don't check if info->shared again.
Maciej
binutils-vax-reloc-shared.patch
Index: binutils/bfd/elf32-vax.c
===================================================================
--- binutils.orig/bfd/elf32-vax.c
+++ binutils/bfd/elf32-vax.c
@@ -1692,8 +1692,7 @@ elf_vax_relocate_section (bfd *output_bf
}
if ((input_section->flags & SEC_CODE) != 0
- || (info->shared
- && ELF32_R_TYPE (outrel.r_info) != R_VAX_32
+ || (ELF32_R_TYPE (outrel.r_info) != R_VAX_32
&& ELF32_R_TYPE (outrel.r_info) != R_VAX_RELATIVE
&& ELF32_R_TYPE (outrel.r_info) != R_VAX_COPY
&& ELF32_R_TYPE (outrel.r_info) != R_VAX_JMP_SLOT