This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Print addend as signed in objdump

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
Cc: binutils at sourceware dot org
Date: Mon, 14 May 2012 05:37:15 -0700
Subject: Re: PATCH: Print addend as signed in objdump
References: <20120512145319.GA942@intel.com> <201205140840.q4E8eP2w028744@ignucius.se.axis.com>

On Mon, May 14, 2012 at 1:40 AM, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>> Date: Sat, 12 May 2012 16:53:19 +0200
>
>> + ? ? ? * objdump.c (disassemble_bytes): Print addend as signed.
>> + ? ? ? (dump_reloc_set): Likewise.
>
> Causing, for cris-elf:
>
> Running /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/cris/cris.exp ...
> FAIL: PIC relocs.
> FAIL: TLS non-PIC relocs.
> FAIL: TLS PIC relocs.
>
> Adjusting all test-cases goes along with adjusting objdump, just
> as with readelf. ?Thanks.
>
> brgds, H-P

I checked in this patch.

-- 
H.J.
---
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gas/testsuite/ChangeLog,v
retrieving revision 1.2030
diff -u -p -r1.2030 ChangeLog
--- ChangeLog	14 May 2012 02:39:58 -0000	1.2030
+++ ChangeLog	14 May 2012 12:22:51 -0000
@@ -1,3 +1,9 @@
+2012-05-14  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* gas/cris/rd-pic-1.d: Expect addend as signed.
+	* gas/cris/rd-tls-1.d: Likewise.
+	* gas/cris/rd-tls-2.d: Likewise.
+
 2012-05-13  H.J. Lu  <hongjiu.lu@intel.com>

 	* gas/all/fwdexp.d: Expect addend as signed.
Index: gas/cris/rd-pic-1.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/cris/rd-pic-1.d,v
retrieving revision 1.3
diff -u -p -r1.3 rd-pic-1.d
--- gas/cris/rd-pic-1.d	15 Jun 2003 23:46:37 -0000	1.3
+++ gas/cris/rd-pic-1.d	14 May 2012 12:22:51 -0000
@@ -28,31 +28,31 @@ Disassembly of section \.text:
 [ 	]+3a:[ 	]+af9e 0000 0000[ 	]+sub\.d 0 <start>,\$?r9
 [ 	]+3c:[ 	]+R_CRIS_32_GOTREL	extsym4\+0x2a
 [ 	]+40:[ 	]+af3e 0000 0000[ 	]+sub\.d 0 <start>,\$?r3
-[ 	]+42:[ 	]+R_CRIS_32_GOTREL	extsym4\+0x[f]+fffffa0
+[ 	]+42:[ 	]+R_CRIS_32_GOTREL	extsym4-0x60
 [ 	]+46:[ 	]+6fad 0000 0000 287a[ 	]+add\.d \[\$?r10\+0 <start>\],\$?r7,\$?r8
 [ 	]+48:[ 	]+R_CRIS_32_GOT	extsym3\+0x38
 [ 	]+4e:[ 	]+6f5d 0000 0000 611a[ 	]+move\.d \[\$?r5\+0 <start>\],\$?r1
 [ 	]+50:[ 	]+R_CRIS_32_GOT	extsym6\+0xa
 [ 	]+56:[ 	]+6fad 0000 0000 284a[ 	]+add\.d \[\$?r10\+0 <start>\],\$?r4,\$?r8
-[ 	]+58:[ 	]+R_CRIS_32_GOT	extsym3\+0x[f]+ffffdd0
+[ 	]+58:[ 	]+R_CRIS_32_GOT	extsym3-0x230
 [ 	]+5e:[ 	]+6f5d 0000 0000 6cca[ 	]+move\.d \[\$?r5\+0 <start>\],\$?r12
-[ 	]+60:[ 	]+R_CRIS_32_GOT	extsym6\+0x[f]+fffff92
+[ 	]+60:[ 	]+R_CRIS_32_GOT	extsym6-0x6e
 [ 	]+66:[ 	]+6f5d 0000 0000 69ce[ 	]+move\.d \[\$?r9=\$?r5\+0 <start>\],\$?r12
-[ 	]+68:[ 	]+R_CRIS_32_GOT	extsym6\+0x[f]+fffff24
+[ 	]+68:[ 	]+R_CRIS_32_GOT	extsym6-0xdc
 [ 	]+6e:[ 	]+6f3d 0000 0000 67de[ 	]+move\.d \[\$?r7=\$?r3\+0 <start>\],\$?r13
-[ 	]+70:[ 	]+R_CRIS_32_GOTREL	extsym10\+0x[f]+ffffeb6
+[ 	]+70:[ 	]+R_CRIS_32_GOTREL	extsym10-0x14a
 [ 	]+76:[ 	]+6f5e 0000 0000[ 	]+move\.d 0 <start>,\$?r5
 [ 	]+78:[ 	]+R_CRIS_32_PLT_PCREL	extsym7\+0x4
 [ 	]+7c:[ 	]+6f9e 0000 0000[ 	]+move\.d 0 <start>,\$?r9
-[ 	]+7e:[ 	]+R_CRIS_32_PLT_PCREL	extsym7\+0x[f]+fffffd8
+[ 	]+7e:[ 	]+R_CRIS_32_PLT_PCREL	extsym7-0x28
 [ 	]+82:[ 	]+6f5e 0000 0000[ 	]+move\.d 0 <start>,\$?r5
 [ 	]+84:[ 	]+R_CRIS_32_PLT_GOTREL	extsym11\+0x10
 [ 	]+88:[ 	]+6f9e 0000 0000[ 	]+move\.d 0 <start>,\$?r9
-[ 	]+8a:[ 	]+R_CRIS_32_PLT_GOTREL	extsym12\+0x[f]+fffffc4
+[ 	]+8a:[ 	]+R_CRIS_32_PLT_GOTREL	extsym12-0x3c
 [ 	]+8e:[ 	]+5fcd 0000 a89a[ 	]+sub\.d \[\$?r12\+0\],\$?r9,\$?r8
-[ 	]+90:[ 	]+R_CRIS_16_GOT	extsym3\+0x[f]+fffff64
+[ 	]+90:[ 	]+R_CRIS_16_GOT	extsym3-0x9c
 [ 	]+94:[ 	]+5fbd 0000 699a[ 	]+move\.d \[\$?r11\+0\],\$?r9
-[ 	]+96:[ 	]+R_CRIS_16_GOTPLT	extsym14\+0x[f]+fffff00
+[ 	]+96:[ 	]+R_CRIS_16_GOTPLT	extsym14-0x100
 [ 	]+9a:[ 	]+6fad 0000 0000 287a[ 	]+add\.d \[\$?r10\+0 <start>\],\$?r7,\$?r8
 [ 	]+9c:[ 	]+R_CRIS_32_GOTPLT	extsym3\+0x38
 [ 	]+\.\.\.
Index: gas/cris/rd-tls-1.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/cris/rd-tls-1.d,v
retrieving revision 1.3
diff -u -p -r1.3 rd-tls-1.d
--- gas/cris/rd-tls-1.d	20 Dec 2008 00:28:58 -0000	1.3
+++ gas/cris/rd-tls-1.d	14 May 2012 12:22:51 -0000
@@ -18,11 +18,11 @@ Disassembly of section \.text:
 [ 	]+18:[ 	]+af9e 0000 0000[ 	]+sub\.d 0 <start>,\$?r9
 [ 	]+1a:[ 	]+R_CRIS_32_GD	extsym4\+0x2a
 [ 	]+1e:[ 	]+af3e 0000 0000[ 	]+sub\.d 0 <start>,\$?r3
-[ 	]+20:[ 	]+R_CRIS_32_GD	extsym4\+0xffffffa0
+[ 	]+20:[ 	]+R_CRIS_32_GD	extsym4-0x60
 [ 	]+24:[ 	]+6f3d 0000 0000 67de[ 	]+move\.d \[\$?r7=\$?r3\+0 <start>\],\$?r13
-[ 	]+26:[ 	]+R_CRIS_32_GD	extsym10\+0xfffffeb6
+[ 	]+26:[ 	]+R_CRIS_32_GD	extsym10-0x14a
 [ 	]+2c:[ 	]+5fbd 0000 699a[ 	]+move\.d \[\$?r11\+0\],\$?r9
-[ 	]+2e:[ 	]+R_CRIS_16_TPREL	extsym14\+0xffffff00
+[ 	]+2e:[ 	]+R_CRIS_16_TPREL	extsym14-0x100
 [ 	]+32:[ 	]+6fad 0000 0000 287a[ 	]+add\.d \[\$?r10\+0 <start>\],\$?r7,\$?r8
 [ 	]+34:[ 	]+R_CRIS_32_TPREL	extsym3\+0x38
 [ 	]+3a:[ 	]+7f0d 0000 0000 611a[ 	]+move.d \[0 <start>],\$?r1
Index: gas/cris/rd-tls-2.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/cris/rd-tls-2.d,v
retrieving revision 1.1
diff -u -p -r1.1 rd-tls-2.d
--- gas/cris/rd-tls-2.d	4 Oct 2008 17:23:44 -0000	1.1
+++ gas/cris/rd-tls-2.d	14 May 2012 12:22:51 -0000
@@ -22,27 +22,27 @@ Disassembly of section \.text:
 [ 	]+24:	af9e 0000 0000[ 	]+sub\.d 0 <start>,\$?r9
 [ 	]+26: R_CRIS_32_DTPREL	extsym4\+0x16
 [ 	]+2a:	9f3e 0000[ 	]+sub\.w 0x0,\$?r3
-[ 	]+2c: R_CRIS_16_DTPREL	extsym4\+0xffffffaa
+[ 	]+2c: R_CRIS_16_DTPREL	extsym4-0x56
 [ 	]+2e:	6f3d 0000 0000 aa4a[ 	]+sub\.d \[\$?r3\+0 <start>\],\$?r4,\$?r10
 [ 	]+30: R_CRIS_32_GOT_TPREL	extsym3
 [ 	]+36:	af9e 0000 0000[ 	]+sub\.d 0 <start>,\$?r9
 [ 	]+38: R_CRIS_32_GOT_GD	extsym4\+0x2a
 [ 	]+3c:	af3e 0000 0000[ 	]+sub\.d 0 <start>,\$?r3
-[ 	]+3e: R_CRIS_32_GOT_TPREL	extsym4\+0xffffffa0
+[ 	]+3e: R_CRIS_32_GOT_TPREL	extsym4-0x60
 [ 	]+42:	6fad 0000 0000 287a[ 	]+add\.d \[\$?r10\+0 <start>\],\$?r7,\$?r8
 [ 	]+44: R_CRIS_32_GOT_TPREL	extsym3\+0x38
 [ 	]+4a:	6f5d 0000 0000 611a[ 	]+move\.d \[\$?r5\+0 <start>\],\$?r1
 [ 	]+4c: R_CRIS_32_GOT_TPREL	extsym6\+0xa
 [ 	]+52:	6fad 0000 0000 284a[ 	]+add\.d \[\$?r10\+0 <start>\],\$?r4,\$?r8
-[ 	]+54: R_CRIS_32_GOT_TPREL	extsym3\+0xfffffdd0
+[ 	]+54: R_CRIS_32_GOT_TPREL	extsym3-0x230
 [ 	]+5a:	6f5d 0000 0000 6cca[ 	]+move\.d \[\$?r5\+0 <start>\],\$?r12
-[ 	]+5c: R_CRIS_32_GOT_TPREL	extsym6\+0xffffff92
+[ 	]+5c: R_CRIS_32_GOT_TPREL	extsym6-0x6e
 [ 	]+62:	6f5d 0000 0000 69ce[ 	]+move\.d \[\$?r9=\$?r5\+0 <start>\],\$?r12
-[ 	]+64: R_CRIS_32_GOT_TPREL	extsym6\+0xffffff24
+[ 	]+64: R_CRIS_32_GOT_TPREL	extsym6-0xdc
 [ 	]+6a:	5fcd 0000 a89a[ 	]+sub\.d \[\$?r12\+0\],\$?r9,\$?r8
-[ 	]+6c: R_CRIS_16_GOT_TPREL	extsym3\+0xffffff64
+[ 	]+6c: R_CRIS_16_GOT_TPREL	extsym3-0x9c
 [ 	]+70:	5fbd 0000 699a[ 	]+move\.d \[\$?r11\+0\],\$?r9
-[ 	]+72: R_CRIS_16_GOT_GD	extsym14\+0xffffff00
+[ 	]+72: R_CRIS_16_GOT_GD	extsym14-0x100
 [ 	]+76:	6fad 0000 0000 287a[ 	]+add\.d \[\$?r10\+0 <start>\],\$?r7,\$?r8
 [ 	]+78: R_CRIS_32_GOT_GD	extsym3\+0x38
 [ 	]+\.\.\.

Follow-Ups:
- Re: PATCH: Print addend as signed in objdump
  - From: Alan Modra

References:
- PATCH: Print addend as signed in objdump
  - From: H.J. Lu
- Re: PATCH: Print addend as signed in objdump
  - From: Hans-Peter Nilsson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]