Re: PATCH: PR ld/3351: aborting at elflink.c line 6778 in elf_link_check_versioned_symbol

[Alan Modra <amodra at gmail dot com>]

On Mon, Jul 02, 2012 at 06:56:37AM -0700, H.J. Lu wrote:
> bfd/
> 
> 2006-10-17  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR ld/3351
> 	* elflink.c (_bfd_elf_update_dynamic_flags): New.
> 	(_bfd_elf_merge_symbol): Update both real and indirect symbol
> 	dynamic flags.
> 	(_bfd_elf_add_default_symbol): Make the real symbol dynamic if
> 	the indirect symbol is defined in a shared library.
> 	(elf_link_add_object_symbols): Likewise.  If the indirect
> 	symbol has been forced local, don't make the real symbol
> 	dynamic.
> 	(elf_link_check_versioned_symbol): Check indirect symbol.
> 	(elf_link_output_extsym): Use real symbol definition when
> 	reporting indirect symbol error.  Check version info for
> 	dynamic versioned symbol.
> 
> ld/testsuite/
> 
> 2006-10-17  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR ld/3351
> 	* ld-elf/indirect.exp: New file.
> 	* ld-elf/indirect1a.c: Likewise.
> 	* ld-elf/indirect1b.c: Likewise.
> 	* ld-elf/indirect1c.c: Likewise.
> 	* ld-elf/indirect2.c: Likewise.
> 	* ld-elf/indirect3.out: Likewise.
> 	* ld-elf/indirect3a.c: Likewise.
> 	* ld-elf/indirect3b.c: Likewise.
> 	* ld-elf/indirect3c.c: Likewise.
> 	* ld-elf/indirect4.out: Likewise.
> 	* ld-elf/indirect4a.c: Likewise.
> 	* ld-elf/indirect4b.c: Likewise.
> 	* ld-elf/indirect4c.c: Likewise.

OK if you ensure your changes cause no failures on the list of targets
in http://sourceware.org/ml/binutils/2012-05/msg00262.html plus one
nacl target.  Please do check all testsuite additions before
committing.  I see
hppa64-hp-hpux11.23  +FAIL: weak and common directives
hppa64-hp-hpux11.23  +FAIL: common and weak directives
from a recent commit of yours.

-- 
Alan Modra
Australia Development Lab, IBM