This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [AArch64] Binutils/gas/ld port for ARM's new 64-bit architecture, AArch64 [3/6] bfd changes


> +  if (_bfd_dwarf2_find_nearest_line (abfd, dwarf_debug_sections,
> +				     section, symbols, offset,
> +				     filename_ptr, functionname_ptr,
> +				     line_ptr, 0,
> +				     &elf_tdata
> +				     (abfd)->dwarf2_find_line_info))

_bfd_dwarf2_find_nearest_line has more parameters than that.

Please don't put the function name and opening paren on different
lines, it's confusing (personal preference).  Yes, I know it's a long
line, but it *looks* like there's a comma missing.

Also, there were a lot of "errors" from -Werror, I had to disable that
to do a test build.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]