This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/5] remove deleted BFDs from the archive cache


>>>>> "HJ" == H J Lu <hjl.tools@gmail.com> writes:

HJ> The original codes were written in such a way to properly handle
HJ> archive operation.

I don't agree.  The original codes were inconsistent in what they did,
presumably because BFD gave no guidance as to what was correct.

HJ> The only missing part was to properly handle the member cache
HJ> pointer.

BFD also leaked the archive member hash tables.

HJ> I think we should open a new bug to track the original problem with
HJ> a testcase and to see if there is a less intrusive way to fix it
HJ> instead making major changes to archive handling codes.

If you mean reverting the patches, I don't agree with it, but that is up
to you.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]