This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA/ARM 18/21] Add support for AES instructions.
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Richard Earnshaw <rearnsha at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 23 Aug 2012 17:46:21 +0100
- Subject: Re: [RFA/ARM 18/21] Add support for AES instructions.
- References: <cover.1345733341.git.matthew.gretton-dann@arm.com> <20120823150448.GU4624@e103070-lin.arm.com> <50365D5C.4060302@arm.com>
On 23/08/12 17:42, Richard Earnshaw wrote:
> On 23/08/12 16:04, Matthew Gretton-Dann wrote:
>>
>> ARMv8 adds several AES instructions for A32 and T32.
>>
>> This patch adds support for these.
>>
>> gas/ChangeLog:
>> 2012-08-23 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>>
>> * config/tc-arm.c (NEON_ENC_TAB): Add aes entry.
>> (neon_type_mask): Add N_UNT.
>> (neon_check_type): Don't always decay typed to untyped sizes.
>> (do_crypto_2op_1): New function.
>> (do_aese): Likewise.
>> (do_aesd): Likewise.
>> (do_aesmc.8): Likewise.
>> (do_aesimc.8): Likewise.
>> (insns): Add AES instructions.
>>
>> gas/testsuite/ChangeLog:
>> 2012-08-23 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>>
>> * gas/arm/armv8-a+crypto.d: New testcase.
>> * gas/arm/armv8-a+crypto.s: Likewise.
>>
>> opcodes/ChangeLog:
>> 2012-08-23 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>>
>> * arm-dis.c (neon_opcodes): Add support for AES instructions.
>>
>
> OK, apart from:
>
>
>> /* Overall per-instruction processing. */
>
> It looks like you've got a tab, rather than two spaces at the end of
> this comment.
>
>
>
>
Hmm, just realized, that wasn't a line that was changed, so the problem
is pre-existing. Perhaps you could fix it anyway.
R.