This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add support for new ABI choice e_flags values on ARM


On Thu, Aug 30, 2012 at 01:21:42PM +0000, Joseph S. Myers wrote:
>On Thu, 30 Aug 2012, Steve McIntyre wrote:
>
>> gas:
>>     * config/tc-arm.c (md_begin): Use the new ARM
>>     hard-float/soft-float ABI flags for EABI_VER5
>
>This seems wrong; the ABI is that these flags are only set in ET_EXEC and 
>ET_DYN objects.  This means the assembler should have nothing to do with 
>them; rather, the linker should set them based on the build attributes in 
>its input files, if producing ET_EXEC or ET_DYN output.  (And there should 
>be testcases added to the linker testsuite for this: that they are set 
>for such output, but not for ld -r links.)

ACK, I'll try that. Thanks for the quick review.

Cheers,
-- 
Steve McIntyre                                steve.mcintyre@linaro.org
<http://www.linaro.org/> Linaro.org | Open source software for ARM SoCs


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]