This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH][GAS][ARM] Gas erroneously accepts ld<cc>s[hb] mnemonics
- From: "Kyrylo Tkachov" <kyrylo dot tkachov at arm dot com>
- To: <binutils at sourceware dot org>
- Cc: "Richard Earnshaw" <Richard dot Earnshaw at arm dot com>
- Date: Tue, 9 Oct 2012 13:34:11 +0100
- Subject: RE: [PATCH][GAS][ARM] Gas erroneously accepts ld<cc>s[hb] mnemonics
- References: <001601cda15a$39c4f4b0$ad4ede10$@tkachov@arm.com>
Ping.
-----Original Message-----
From: binutils-owner@sourceware.org [mailto:binutils-owner@sourceware.org]
On Behalf Of Kyrylo Tkachov
Sent: 03 October 2012 12:29
To: binutils@sourceware.org
Subject: [PATCH][GAS][ARM] Gas erroneously accepts ld<cc>s[hb] mnemonics
Sorry, the previous message was messed up by my email client.
Hello,
Gas accepts the condition codes for the ldsh and ldsb after the second
character when they should be
after the third one (i.e. lds<cc>[hb] instead of ld<cc>s[hb]). This patch
fixes that and removes the unused
macros that remain after the change.
Ok for trunk?
Thanks,
Kyrill
gas/
2012-10-03 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* config/tc-arm.c: Change condition code insertion for
lds[hb] instructions from after the 2nd character to after the 3rd.
(tCM): Remove macro.
(TxCM): Likewise.
(TxCM_): Likewise.
(TCM): Likewise.
gas/testsuite
2012-10-03 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* gas/arm/ldgesb-bad.d: New file.
* gas/arm/ldgesb-bad.l: Likewise.
* gas/arm/ldgesb-bad.s: Likewise.
* gas/arm/ldgesh-bad.d: Likewise.
* gas/arm/ldgesh-bad.l: Likewise.
* gas/arm/ldgesh-bad.s: Likewise.
* gas/arm/ldsgeb.d: Likewise.
* gas/arm/ldsgeb.s: Likewise.
* gas/arm/ldsgeb.l: Likewise.
* gas/arm/ldsgeh.d: Likewise.
* gas/arm/ldsgeh.s: Likewise.
* gas/arm/ldsgeh.l: Likewise.