This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] microMIPS/GAS: Unbreak fixed-size delay slot handling
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: <binutils at sourceware dot org>, Chao-ying Fu <fu at mips dot com>
- Date: Thu, 1 Nov 2012 23:03:31 +0000
- Subject: Re: [PATCH] microMIPS/GAS: Unbreak fixed-size delay slot handling
- References: <alpine.DEB.1.10.1210242331280.9406@tp.orcam.me.uk> <871ugmna5c.fsf@talisman.home>
On Thu, 25 Oct 2012, Richard Sandiford wrote:
> OK, but:
>
> "Maciej W. Rozycki" <macro@codesourcery.com> writes:
> > @@ -2315,7 +2326,8 @@ is_delay_slot_valid (const struct mips_o
> > return TRUE;
> >
> > if (mo->pinfo == INSN_MACRO)
> > - return TRUE;
> > + return ((history[0].insn_mo->pinfo2 & INSN2_BRANCH_DELAY_16BIT) == 0
> > + ? TRUE : FALSE);
>
> please just use:
>
> return (history[0].insn_mo->pinfo2 & INSN2_BRANCH_DELAY_16BIT) == 0;
I have applied this now (as two separate commits, sorry about that),
thanks for your review.
Maciej