This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch 1/9] Nios II port, top-level configury
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 24 Jan 2013 20:46:34 +0000
- Subject: Re: [patch 1/9] Nios II port, top-level configury
- References: <51019200.3040908@codesourcery.com>
On Thu, 24 Jan 2013, Sandra Loosemore wrote:
> This patch makes the top-level configure script know about Nios II.
I don't understand why these changes are needed.
* An assignment noconfigdirs="$noconfigdirs" certainly seems useless.
* Logic along the lines of the
skipdirs=`echo " ${skipdirs} " | sed -e 's/ gprof / /'`
is what would be used if a directory were disabled in skipdirs by default
for a certain set of configurations, but this configuration is special so
shouldn't disable it after all. For example, that's used by --with-newlib
to ensure newlib is built even for native configurations. But I don't see
why gprof would be in skipdirs in the first place, and you don't say
what's special about nios2 to mean such a default should be changed for
it.
--
Joseph S. Myers
joseph@codesourcery.com