This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS/opcodes: Correct mixed-mode disassembly
On Wed, 13 Feb 2013, Richard Sandiford wrote:
> > opcodes/
> > * mips-dis.c (is_compressed_mode_p): Only match symbols from the
> > section disassembled.
> >
> > binutils/testsuite/
> > * binutils-all/mips/mixed-micromips.d: New test.
> > * binutils-all/mips/mixed-mips16.d: New test.
> > * binutils-all/mips/mixed-micromips.s: New test source.
> > * binutils-all/mips/mixed-mips16.s: New test source.
> > * binutils-all/mips/mips.exp: New file.
>
> OK, thanks.
Thanks, applied. However I would like to apply this small adjustment on
top of this, just for the sake of code correctness. OK?
2013-02-13 Maciej W. Rozycki <macro@codesourcery.com>
binutils/testsuite/
* binutils-all/mips/mixed-mips16.s: Add missing stack adjustment.
* binutils-all/mips/mixed-mips16.d: Update accordingly.
Maciej
binutils-opcodes-mips-symbol-sec-fix.diff
Index: binutils-fsf-trunk-quilt/binutils/testsuite/binutils-all/mips/mixed-mips16.d
===================================================================
--- binutils-fsf-trunk-quilt.orig/binutils/testsuite/binutils-all/mips/mixed-mips16.d 2013-02-13 19:28:27.535475862 +0000
+++ binutils-fsf-trunk-quilt/binutils/testsuite/binutils-all/mips/mixed-mips16.d 2013-02-13 18:58:02.465503691 +0000
@@ -26,5 +26,5 @@
[0-9a-f]+ <[^>]*> 6500 nop
[0-9a-f]+ <[^>]*> 9707 lw a3,28\(sp\)
[0-9a-f]+ <[^>]*> ef00 jr a3
-[0-9a-f]+ <[^>]*> 6500 nop
+[0-9a-f]+ <[^>]*> 6304 addiu sp,32
\.\.\.
Index: binutils-fsf-trunk-quilt/binutils/testsuite/binutils-all/mips/mixed-mips16.s
===================================================================
--- binutils-fsf-trunk-quilt.orig/binutils/testsuite/binutils-all/mips/mixed-mips16.s 2013-02-13 19:28:27.535475862 +0000
+++ binutils-fsf-trunk-quilt/binutils/testsuite/binutils-all/mips/mixed-mips16.s 2013-02-13 18:56:36.845032380 +0000
@@ -25,6 +25,7 @@
sw $ra, 28($sp)
jal baz
lw $a3, 28($sp)
+ addiu $sp, 32
jr $a3
.end bar