This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GOLD] powerpc64 ODR violation check

On Wed, Mar 06, 2013 at 06:33:18AM -0800, Ian Lance Taylor wrote:
> Why bother with has_func_descriptors?  Also I don't see a need for
> allocation here.  How about
> 
>     Symbol_location tloc;
>     parameters->target().function_location(loc, &tloc);
>     // Now use tloc instead of loc.
> 
> And the default definition of function_location is
> 
>     void do_function_location(const Symbol_location& loc, Symbol_location* tloc)
>     {
>         *tloc = loc;
>     }

Thanks for the review!  Yes, that is nicer.

-- 
Alan Modra
Australia Development Lab, IBM
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]