This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFC: BFD PATCH] Removing other warning using clang


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi all,

I'd like to submit another patch to remove other warnings thrown by
clang. Some changes are trivial, but one need a small review.
The problem is in elf32-xtensa.c, where there are two memset() like:

memset (sec_cache, 0, sizeof (sec_cache));     (1)

sec_cache is a pointer to a structure, so I guess the original intention was:

memset (sec_cache, 0, sizeof (*sec_cache));    (2)

otherwise, if the idea was zeroing the pointer, a:

sec_cache = NULL;                              (3)

would be enough.
The patch I'm submitting is implementing (2).

Thanks in advance.

Best regards,
Luca

2013/04/19 Luca Pizzamiglio <luca.pizzamiglio@gmail.com>

bfd/
    * ecoff.c: casting the return value of BFD_ALIGN to int
    * elf32-tic6x.c: removing unused variables
    * elf32-v85a.c: redefine the type of a variable (int -> bfd_vma)
    * elf32-xtensa.c: the sizeof() using the right variable
    * vms-apha.c: initialize a variable
-----BEGIN PGP SIGNATURE-----
Version: APG v1.0.8

iQJLBAEBCAA1BQJRcVTBLhxMdWNhIFBpenphbWlnbGlvIDxsdWNhLnBpenphbWln
bGlvQGdtYWlsLmNvbT4ACgkQ1r9Hhyzd6UUC0hAAriujn27SB9kVBXsKeSQzOed+
IAlwM8LhnLZCpJAOksU0ieagouJmFh8OooQwO+1GatsBa19egBEDXCklejJlX8FG
BnTbeY8q8PX1MTWO0BcQstU8AWHorpzHmY+07hxPVWZyN+1YWiJxBRaIgjgMr0i6
Pgchvp+rabiz+YMPDxr+vwRq2dk0o0HezZ+57Yo9/vRxgC3ZTSwyZBRJcRORpuLO
BWd6uTbyB1R1LnF5uW80xUj5rPYEitJJo+bIeZa/9MVMwqDxK1/gerg57yb3V3l5
3tyyons4UbOLG+Z72tjV863n9F8KzWzrTXNSHHC95MTJ3UalcD1P/8TCxK7r175w
zOb3hg3ioUGoi5fjHHXH7sVoMdi+uEaH197U8XEEvDghFD2aB+n8MOk+YWBH2li9
L8CaBtkWeNv/77F26baXIRSk3xjGjWQHyNCqjF9jUPLjD5+PPvAs4xzfy1UL+wST
HhOyrFDcr+X9vUtyxCYgoBTJnTAXzfS+YRbMAQc7litTRN0UM6TbC5NVZ+MjELoD
fd5pYE9C07vLb0ifdfYRY4U8HcVyYGnWxkKNcG9Do7Q7LwB3hxTKVhLSCoq0wXj4
fK+JCbBuJQ0eQ3L1B+X/P1XsmZcxn0L6z2wVcDgh50CfpmXFqivy7CgpSnU7pk2k
zSMi3FOAZi4SBhtt0YA=
=rv5Y
-----END PGP SIGNATURE-----

Attachment: patch-bfd-cumulative.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]