Re: [RFC] msp430 instruction decoder

[Mike Frysinger <vapier at gentoo dot org>]

On Thursday 16 May 2013 18:02:46 Kevin Buettner wrote:
> --- /dev/null   1 Jan 1970 00:00:00 -0000
> +++ msp430-decode.c     16 May 2013 21:31:35 -0000

typically it's better to omit generated files from patches posted to the list.  
it's often times a lot of noise (like in this case).

> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ msp430-decode.opc	16 May 2013 21:31:35 -0000
> @@ -0,0 +1,572 @@
> +/* -*- c -*- */

missing standard copyright/license block

> +typedef struct
> +{
> +  MSP430_Opcode_Decoded * msp430;

shouldn't the style be:
	MSP430_Opcode_Decoded *msp430;

seems like general style guidelines are violated a lot in this file.  do we 
normally ignore that in the opcodes/ tree ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.