This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold patch] RFC: Add extra note when 'vtable for C' is undefined


On Tue, May 21, 2013 at 11:56 AM, Cary Coutant <ccoutant@google.com> wrote:
>
> Ian, I'm doing a simple check for "_ZTV" here -- for a bit of extra
> portability, I could also demangle the symbol name into components and
> look for DEMANGLE_COMPONENT_VTABLE, but it just didn't seem worth it.

I agree.

> Also, I could have put the check in gold_undefined_symbol_at_location,
> or in Errors::undefined_symbol. Do you have any preference?

I think that where you have it is fine, especially if you wind up
making it smarter.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]