This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] RFC: Add extra note when 'vtable for C' is undefined
- From: Cary Coutant <ccoutant at google dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 21 May 2013 14:15:20 -0700
- Subject: Re: [gold patch] RFC: Add extra note when 'vtable for C' is undefined
- References: <CAHACq4pERm+JYnoX7u57zUpBn3jJzBuC3dZ5Se_dwnZqGh7sEQ at mail dot gmail dot com> <CAKOQZ8xRKXVhirZeBOsZmDTN132xuehbNa1tcj6a4YcC0nb-MQ at mail dot gmail dot com>
>> Ian, I'm doing a simple check for "_ZTV" here -- for a bit of extra
>> portability, I could also demangle the symbol name into components and
>> look for DEMANGLE_COMPONENT_VTABLE, but it just didn't seem worth it.
>
> I agree.
>
>> Also, I could have put the check in gold_undefined_symbol_at_location,
>> or in Errors::undefined_symbol. Do you have any preference?
>
> I think that where you have it is fine, especially if you wind up
> making it smarter.
Thanks, I've committed it as is.
-cary