This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch AArch64] gprof support for AArch64
- From: Alan Modra <amodra at gmail dot com>
- To: Venkataramanan Kumar <venkataramanan dot kumar at linaro dot org>
- Cc: binutils at sourceware dot org, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, Richard Earnshaw <rearnsha at arm dot com>, Patch Tracking <patch at linaro dot org>
- Date: Wed, 22 May 2013 09:24:08 +0930
- Subject: Re: [Patch AArch64] gprof support for AArch64
- References: <CAJK_mQ0v_KJme4JqoQh34y=L7+G-Vq3xkX+R2GGSnYMU8KrKCw at mail dot gmail dot com>
OK, except
On Tue, May 21, 2013 at 07:52:58PM +0530, Venkataramanan Kumar wrote:
> + if (((insn & 0xfc000000) == BRANCHANDLINK)
> + ||((insn & 0xfc000000) == BRANCH))
Remove excess parentheses, add space after ||.
> + {
> + DBG (CALLDEBUG,
> + printf ("[find_call] 0x%lx: bl", (unsigned long) pc));
> +
> + /* Regular pc relative addressing check that this is the
> + address of a function. */
> + offset = ((insn & 0x3ffffff) << 2) & ((1U << 28) - 1);
No need to mask with "& ((1U << 28) - 1)".
--
Alan Modra
Australia Development Lab, IBM