Re: [Patch AArch64] gprof support for AArch64

[Venkataramanan Kumar <venkataramanan dot kumar at linaro dot org>]

Hi Alan,

I have incorporated your comments.

I do'nt have write access, so will wait for someone  to commit on my behalf.

regards,
Venkat.

On 22 May 2013 05:24, Alan Modra <> wrote:
> OK, except
>
> On Tue, May 21, 2013 at 07:52:58PM +0530, Venkataramanan Kumar wrote:
>> +      if (((insn & 0xfc000000) == BRANCHANDLINK)
>> +       ||((insn & 0xfc000000) == BRANCH))
>
> Remove excess parentheses, add space after ||.
>
>> +     {
>> +       DBG (CALLDEBUG,
>> +            printf ("[find_call] 0x%lx: bl", (unsigned long) pc));
>> +
>> +       /* Regular pc relative addressing check that this is the
>> +           address of a function.  */
>> +       offset = ((insn & 0x3ffffff) << 2)  & ((1U << 28) - 1);
>
> No need to mask with "& ((1U << 28) - 1)".
>
> --
> Alan Modra
> Australia Development Lab, IBM

Attachment: aarch64.gprof.patch
Description: Binary data