This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Support VU0 on MIPS R5900
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: JÃrgen Urban <JuergenUrban at gmx dot de>
- Cc: binutils at sourceware dot org
- Date: Wed, 22 May 2013 19:08:28 +0100
- Subject: Re: [PATCH] Support VU0 on MIPS R5900
- References: <20130108234130 dot 27410 at gmx dot net> <87a9rrso6l dot fsf at talisman dot default> <trinity-357f2c0f-746d-43de-b9dc-6053dff9d1f2-1369080004599 at 3capp-gmx-bs18> <87li79l3bj dot fsf at talisman dot default> <trinity-18e8b087-1257-47a7-8f47-4c6c91dbeb7d-1369179916128 at 3capp-gmx-bs47>
"JÃrgen Urban" <JuergenUrban@gmx.de> writes:
> Hello Richard,
>
>> Thanks for the patch. The code itself looks good. However, I think it'd
>> be better to extend the test to include the four branch instructions.
>> It should also cover the LQC2 and SQC2 macros added here:
>
> The new attached patch includes the additional tests. I also added tests
> for sq/lq, because this is similar and was also missing. I fixed also
> some bad comments in the old test.
Thanks, applied with the changelogs below.
Richard
include/opcode/
2013-05-22 JÃrgen Urban <JuergenUrban@gmx.de>
* mips.h (M_LQC2_AB, M_SQC2_AB): New macros.
opcodes/
2013-05-22 JÃrgen Urban <JuergenUrban@gmx.de>
* mips-opc.c (mips_builtin_opcodes): Add R5900 VU0 instructions.
gas/
2013-05-22 JÃrgen Urban <JuergenUrban@gmx.de>
* config/tc-mips.c (macro): Handle M_LQC2_AB and M_SQC2_AB.
gas/testsuite/
2013-05-22 JÃrgen Urban <JuergenUrban@gmx.de>
* gas/mips/r5900-full.s, gas/mips/r5900-full.d: Add tests for LQ
and SQ macros.
* gas/mips/r5900-vu0.s, gas/mips/r5900-vu0.d: New test.
* gas/mips/mips.exp: Run it.