This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Don't align text/data/bss sections in x86 assembler
- From: Roland McGrath <mcgrathr at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 4 Jun 2013 10:57:51 -0700
- Subject: Re: PATCH: Don't align text/data/bss sections in x86 assembler
- References: <20130531173241 dot GA30259 at intel dot com> <CAB=4xhqoDKXgE1bzD+tj0CaS3ro+8jpEXPnziOcAVMg2hheQNA at mail dot gmail dot com> <CAMe9rOp=pJDW-9xG9NJWe4u1w-9SvqKQf-2=dOwaovwWYG=WDA at mail dot gmail dot com>
On Tue, Jun 4, 2013 at 9:12 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> I prefer to disable them for NACL and add new tests for NACL.
Why? I don't see how the address constants are material to the size tests.
> Before my changes, I see
>
> FAIL: TLS -fno-pic -shared
> FAIL: ld-size/size32-1-i386
> FAIL: ld-size/size32-1-x32
> FAIL: ld-size/size32-1-x86-64
> FAIL: ld-size/size32-2-i386
> FAIL: ld-size/size32-2-x32
> FAIL: ld-size/size32-2-x86-64
> FAIL: ld-size/size32-3-x32
> FAIL: ld-size/size32-3-x86-64
> FAIL: ld-size/size64-1-x32
> FAIL: ld-size/size64-1-x86-64
> FAIL: ld-size/size64-2-x32
> FAIL: ld-size/size64-2-x86-64
> FAIL: TLS -fpic -shared transitions
> FAIL: TLS descriptor -fpic -shared transitions
> FAIL: TLS -fpic and -fno-pic exec transitions
> FAIL: TLS descriptor -fpic and -fno-pic exec transitions
> FAIL: ld-x86-64/ilp32-4-nacl
>
> I checked in this patch to fix 2 extra failures
> caused by my alignment change.
Thanks for fixing the regression. I'll deal with the others at some point.
For now, the x86 NaCl targets are not my highest priority.
Thanks,
Roland