This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Make gas/mips/mips.exp ELF-only
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: Andrew Pinski <apinski at cavium dot com>, <binutils at sourceware dot org>
- Date: Tue, 25 Jun 2013 22:52:02 +0100
- Subject: Re: Make gas/mips/mips.exp ELF-only
- References: <87sj0a3wxd dot fsf at talisman dot default> <alpine dot DEB dot 1 dot 10 dot 1306250154090 dot 16287 at tp dot orcam dot me dot uk> <8738s55148 dot fsf at talisman dot default>
On Tue, 25 Jun 2013, Richard Sandiford wrote:
> >> This patch removes the non-ELF support from the MIPS GAS testsuite.
> >>
> >> *-openbsd was still being classed as aout, even though the modern port
> >> is ELF. *-freebsd and *-kfreebsd-gnu weren't being handled at all,
> >> so most of the testsuite was skipped. All three, along with *-netbsd,
> >> are tradmips targets, so tmips should be "t" for them. This fixes
> >> two MIPS16 reloc failures on NetBSD.
> >>
> >> Tested on the same targets as before and applied.
> >
> > This caused a new failure on mips-sgi-irix5, where I think microMIPS
> > tests were not previously run:
>
> Hmm, are you sure? It was failing before the patches for me.
> (This was one of the "same targets as before".)
>
> The test was only added on 2013-06-13 and AFAICT it has been
> failing on mips-sgi-irix5 since then.
Ah, I see what happened, the test has been broken since the addition of
the microMIPS variant (and its standard MIPS version since its inception):
$ grep 'mips-sgi-irix5.*virt64' gastest_results-161
mips-sgi-irix5 FAIL: virt64 instructions (mips64r2)
mips-sgi-irix5 FAIL: virt64 instructions (octeon)
mips-sgi-irix5 FAIL: virt64 instructions (octeon2)
mips-sgi-irix5 FAIL: virt64 instructions (octeonp)
$ grep 'mips-sgi-irix5.*virt64' gastest_results-162
mips-sgi-irix5 FAIL: virt64 instructions (micromips)
mips-sgi-irix5 FAIL: virt64 instructions (mips64r2)
mips-sgi-irix5 FAIL: virt64 instructions (octeon)
mips-sgi-irix5 FAIL: virt64 instructions (octeon2)
mips-sgi-irix5 FAIL: virt64 instructions (octeonp)
$ ls -la gastest_results-16[12]
-rw-r--r-- 1 maciej eeg 71104 Jun 11 20:35 gastest_results-161
-rw-r--r-- 1 maciej eeg 71034 Jun 25 01:47 gastest_results-162
$
-- sorry about the confusion. It looks to me like this test is missing a
has_newabi qualifier. Cc-ing Andrew -- can you fix it up please?
But I think making the harness fail after a GAS failure (on dump tests,
that is) is a good idea too.
Maciej