This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Commit: RX: Fix decoding of NOP insns


Hi Guys,

  I am applying the patch below to fix a small problem decoding NOP
  instructions on the RX target.  Without this patch the decode would
  interpret "mov.L r0, 3292[r0]" as a no-op rather than a move.

Cheers
  Nick

opcodes/ChangeLog
2013-06-26  Nick Clifton  <nickc@redhat.com>

	* rx-decode.opc (rx_decode_opcode): Check sd field as well as ss
	field when checking for type 2 nop.
	* rx-decode.c: Regenerate.

Index: opcodes/rx-decode.opc
===================================================================
RCS file: /cvs/src/src/opcodes/rx-decode.opc,v
retrieving revision 1.10
diff -u -3 -p -r1.10 rx-decode.opc
--- opcodes/rx-decode.opc	14 Jun 2013 19:57:10 -0000	1.10
+++ opcodes/rx-decode.opc	26 Jun 2013 10:29:38 -0000
@@ -304,7 +304,7 @@ rx_decode_opcode (unsigned long pc AU,
   ID(mov); sBWL (sz); DIs(dst, d*16+sppp, sz); SC(IMM(1)); F_____;
 
 /** 11sz sd ss rsrc rdst	mov%s	%1, %0 */
-  if (ss == 3 && sz == 2 && rsrc == 0 && rdst == 0)
+  if (sd == 3 && ss == 3 && sz == 2 && rsrc == 0 && rdst == 0)
     {
       ID(nop2);
       rx->syntax = "nop";


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]