This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PING] [Patch RX] Added warnings of RX variants that does not have hardware FPU support
- From: DJ Delorie <dj at redhat dot com>
- To: Sandeep Kumar Singh <Sandeep dot Singh2 at kpitcummins dot com>
- Cc: binutils at sourceware dot org, Kaushik dot Phatak at kpitcummins dot com, nickc at redhat dot com
- Date: Fri, 12 Jul 2013 18:07:49 -0400
- Subject: Re: [PING] [Patch RX] Added warnings of RX variants that does not have hardware FPU support
- References: <00D82FEA4EAEB64782676AD908D06E6F2E296D61 at KCHJEXMB03 dot kpit dot com>
These are fine, although...
+ { rx_check_float_support (); id24 (2, 0x72, sub_op << 4); F ($4, 20, 4); O4 ($2); }
the call should be on its own line, like elsewhere:
else
{ rx_relax (RX_RELAX_BRANCH, 0);
rx_linkrelax_branch ();
B1 (0x39); PC2 ($2); } }
Alternatively, putting the call right after the opcode token might
make the error message point to the correct location:
float2_op
: { rx_check_float_support (); }
'#' EXPR ',' REG
{ id24 (2, 0x72, sub_op << 4); F ($4, 20, 4); O4 ($2); }
Watch out for new shift-reduce warnings, though. Sometimes you need
to put actions after distinguishing tokens to keep the parser
predictable.