Re: [PATCH] support arm-nacl-compatible ARM-ARM veneers

[nick clifton <nickc at redhat dot com>]

Hi Roland,


> This makes the arm-nacl backend of BFD ld use NaCl-compatible code for the
> veneers used for ARM calls with caller and callee PC more than 32MB apart.

> bfd/
> 2013-07-12  Roland McGrath  <mcgrathr@google.com>
>
> 	* elf32-arm.c (elf32_arm_stub_long_branch_arm_nacl): New variable.
> 	(elf32_arm_stub_long_branch_arm_nacl_pic): New variable.
> 	(arm_build_one_stub): Increase MAXRELOCS to 3.
> 	(arm_type_of_stub): Use them if GLOBALS->nacl_p.
> 	(struct elf32_arm_link_hash_table): Give add_stub_section member's
> 	pointee type a third argument.
> 	(elf32_arm_create_or_find_stub_sec): Update caller.
> 	(elf32_arm_size_stubs): Update argument type.
> 	* bfd-in.h (elf32_arm_size_stubs): Update decl.
> 	* bfd-in2.h: Regenerate.
> 	* libbfd.h: Regenerate.
>
> ld/
> 2013-07-12  Roland McGrath  <mcgrathr@google.com>
>
> 	* emultempl/armelf.em (elf32_arm_add_stub_section): Take third
> 	argument ALIGNMENT_POWER, use it instead of constant 3.
>
> ld/testsuite/
> 2013-07-12  Roland McGrath  <mcgrathr@google.com>
>
> 	* ld-arm/farcall-arm-nacl.d: New file.
> 	* ld-arm/farcall-arm-nacl-pic.d: New file.
> 	* ld-arm/farcall-data-nacl.d: New file.
> 	* ld-arm/arm-elf.exp (armeabitests_common): Add extra element to
> 	"action" lists for those cases to use a different dump file for NaCl
> 	targets.
> 	Massage $armeabitests_common to drop the extra element or the one
> 	before it, depending on [istarget "arm*-*-nacl*"].
>
> 	* ld-arm/arm-elf.exp (armelftests_common): Move all "Cortex-A8
> 	erratum fix", Thumb-only and interworking cases to ...
> 	(armelftests_nonacl): ... here.
> 	(armeabitests_common): Move all "erratum 760522 fix", Thumb-only
> 	and interworking cases to ...
> 	(armeabitests_nonacl): ... here.

Approved and applied.

Note - in the future please could you provide patches like this as an 
attachment ?  My mailer applied word-wrap formatting to the patch which 
made it very hard to apply...

Cheers
  Nick