This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PING] [Patch RX] Added warnings of RX variants that does not have hardware FPU support
- From: Sandeep Kumar Singh <Sandeep dot Singh2 at kpitcummins dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>, "nickc at redhat dot com" <nickc at redhat dot com>
- Date: Fri, 19 Jul 2013 06:36:37 +0000
- Subject: RE: [PING] [Patch RX] Added warnings of RX variants that does not have hardware FPU support
- References: <00D82FEA4EAEB64782676AD908D06E6F2E296D61 at KCHJEXMB03 dot kpit dot com> <201307122207 dot r6CM7noC032577 at greed dot delorie dot com>
Hi DJ,
Thanks for reviewing my patch and providing your inputs. I am working on your
suggestions, but the patches has been committed by Nick,
http://sourceware.org/ml/binutils/2013-07/msg00171.html
I tried to implement your suggestions, but it is issued below build error,
../src/binutils-2.23.1/gas/config/rx-parse.y:896.45-46: $4 of
`float2_op' has no declared type
../src/binutils-2.23.1/gas/config/rx-parse.y:896.61-62: $2 of
`float2_op' has no declared type
Please suggest as I am not familiar with this syntax.
Thanks & Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India
> -----Original Message-----
> From: DJ Delorie [mailto:dj@redhat.com]
> Sent: Saturday, July 13, 2013 3:38 AM
> To: Sandeep Kumar Singh
> Cc: binutils@sourceware.org; Kaushik Phatak; nickc@redhat.com
> Subject: Re: [PING] [Patch RX] Added warnings of RX variants that does not have
> hardware FPU support
>
>
> These are fine, although...
>
> + { rx_check_float_support (); id24 (2, 0x72, sub_op << 4); F ($4, 20, 4); O4
> ($2); }
>
> the call should be on its own line, like elsewhere:
>
> else
> { rx_relax (RX_RELAX_BRANCH, 0);
> rx_linkrelax_branch ();
> B1 (0x39); PC2 ($2); } }
>
> Alternatively, putting the call right after the opcode token might
> make the error message point to the correct location:
>
> float2_op
> : { rx_check_float_support (); }
> '#' EXPR ',' REG
> { id24 (2, 0x72, sub_op << 4); F ($4, 20, 4); O4 ($2); }
>
> Watch out for new shift-reduce warnings, though. Sometimes you need
> to put actions after distinguishing tokens to keep the parser
> predictable.