This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/AARCH64] Fix elfNN_aarch64_howto_from_bfd_reloc for BFD_RELOC_AARCH64_NONE and ILP32


Looks OK to me (but I cannot approve it).

Yufeng

On 07/23/13 22:45, Andrew Pinski wrote:
Hi,
   The problem here is that the type inside elfNN_aarch64_howto_table
for BFD_RELOC_AARCH64_NONE is 0 since that is the relocation number of
NONE so we return NULL from elfNN_aarch64_howto_from_bfd_reloc but
when really wanted to return a real howto.  This happens with TLS
relaxation code when it is recording a relocation as being none.

This fixes the problem by explicitly checking for
BFD_RELOC_AARCH64_NONE and returning elfNN_aarch64_howto_none.

OK?  Built and tested on aarch64-elf and aarch64-linux-gnu (with a few
extra patches which adds ilp32 support).

Thanks,
Andrew

ChangeLog:
* elfnn-aarch64.c (elfNN_aarch64_howto_from_bfd_reloc): Handle
BFD_RELOC_AARCH64_NONE explicitly.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]