This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] VAX/BFD: Fix GOT/PLT handling for non-preemptible symbols
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: Nick Clifton <nick at nickclifton dot clara dot co dot uk>
- Cc: binutils at sourceware dot org, Matt Thomas <matt at netbsd dot org>, Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Date: Sat, 27 Jul 2013 23:21:50 +0100 (BST)
- Subject: Re: [PATCH] VAX/BFD: Fix GOT/PLT handling for non-preemptible symbols
- References: <alpine dot LFD dot 2 dot 03 dot 1305200111400 dot 10753 at linux-mips dot org> <51B2083A dot 4070302 at nickclifton dot clara dot co dot uk>
On Fri, 7 Jun 2013, Nick Clifton wrote:
> > bfd/
> > * elf32-vax.c (elf_vax_check_relocs) <R_VAX_GOT32, R_VAX_PLT32>:
> > Don't check symbol visibility here. Remove a check already
> > asserted for.
> > (elf_vax_instantiate_got_entries): Use SYMBOL_REFERENCES_LOCAL
> > instead of individual checks.
> > (elf_vax_relocate_section) <R_VAX_GOT32, R_VAX_PLT32>: Only
> > check the offset to decide if produce a GOT or PLT entry.
> > Remove redundant assertions. Remove code to produce GOT entries
> > for local symbols. Remove a duplicate comment and add a comment
> > on GOT relocations.
> > (elf_vax_finish_dynamic_symbol): Remove code to produce RELATIVE
> > dynamic relocs.
> >
> > ld/testsuite/
> > * ld-vax-elf/got-local-exe.xd: New test.
> > * ld-vax-elf/got-local-lib.xd: New test.
> > * ld-vax-elf/got-local-aux.s: New test source.
> > * ld-vax-elf/got-local-def.s: New test source.
> > * ld-vax-elf/got-local-ref.s: New test source.
> > * ld-vax-elf/vax-elf.exp: Run the new tests.
>
> Approved - please apply.
Applied now, thanks for your review.
Maciej