This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Thanks for organizing this patch series so nicely! A couple of general comments: - all patches need ChangeLog entries. (See http://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs.) - don't include generated files like Makefile.in in the diff (just say "Regenerated" in the ChangeLog entry). I'm still working on the big two-part mips.cc patch, but I've got comments on the others for you. First... > 1. start.patch > This patch allows a target to define start symbol. Mips start symbol is "__start" instead of "_start". I decided to do this differently. Rather than add a virtual function to return the entry symbol, I added the symbol name to struct Target_info, and added "_start" as the entry_symbol_name in the Target_info initializers for each target. I've committed the attached patch. You'll need to adjust mips.cc similarly. -cary 2013-07-23 Cary Coutant <ccoutant@google.com> Sasa Stankovic <Sasa.Stankovic@imgtec.com> * parameters.cc (Parameters::entry): Return target-specific entry symbol name. * target.h (Target::entry_symbol_name): New function. (Target_info::entry_symbol_name): New data member. * arm.cc (Target_arm::arm_info): Add entry_symbol_name. * i386.cc (Target_i386::i386_info): Likewise. (Target_i386_nacl::i386_nacl_info): Likewise. * sparc.cc (Target_sparc::sparc_info): Likewise. * tilegx.cc (Target_tilegx::tilegx_info): Likewise. * x86_64.cc: (Target_x86_64::x86_64_info) Likewise. (Target_x86_64_nacl::x86_64_nacl_info) Likewise. * testsuite/testfile.cc (Target_test::test_target_info): Likewise.
Attachment:
gold-entry-symbol-patch.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |